[jonoweb]

On my site each product page has a comment form and my goal here is to get the average rating and put it on the product listing page,
here's what I have but I get an invalid argument error:

PHP Code:

<?php 

function get_product_rating() {

        

        foreach ($products as $product) {

            

            function cmtx_average_rating() { //get average rating



            global $cmtx_mysql_table_prefix, $cmtx_page_id; //globalise variables



            $result = mysql_query("SELECT AVG(rating) FROM `" . $cmtx_mysql_table_prefix . "comments` WHERE `is_approved` = '1' AND `rating` != '0' AND `page_id` = '$cmtx_page_id'");



            $average = mysql_fetch_assoc($result);



            $average = round($average["AVG(rating)"] / 0.5) * 0.5;



            return $average;



            }

        

        } 

            

    } 

[Steven]

I'm not sure where to start here. Can you explain more about your objective, because it doesn't make sense to me how you're approaching it with the code. I assume you have a page with a list of products, and if I were to visit each product I would see its average rating, and what you want to do is display each of those average ratings on the product listing page. So on the product listing page, you have product 1 and its average rating, then product 2 and its average rating, and so on. Is that correct?

I can't see where you are actually calling the cmtx_average_rating() function. It looks like you're just re-creating the same function lots of times. What is the value of the variable $product? How are you supplying the value for the $cmtx_page_id variable? What's the full error message that you're getting?

[jonoweb]

I assume you have a page with a list of products, and if I were to visit each product I would see its average rating, and what you want to do is display each of those average ratings on the product listing page. So on the product listing page, you have product 1 and its average rating, then product 2 and its average rating, and so on. Is that correct?

Yep that is what I want to do.

I can't see where you are actually calling the cmtx_average_rating() function. It looks like you're just re-creating the same function lots of times. What is the value of the variable $product? How are you supplying the value for the $cmtx_page_id variable? What's the full error message that you're getting?

Not sure of the value of $product, how would I find that?

this is my function for commentics:

PHP Code:

<?php 

function comments($key) {



 $cmtx_page_id = "cmtx_reference";

 $cmtx_reference = $key;

 $cmtx_path = "././comments/";

 define('IN_COMMENTICS', 'true'); //no need to edit this line

 require $cmtx_path . "includes/commentics.php"; //no need to edit this line



} 

[Steven]

PHP Code:

<?php

function cmtx_average_rating ($cmtx_page_id) { //get average rating



    global $cmtx_mysql_table_prefix; //globalise variables



    $result = mysql_query("SELECT AVG(rating) FROM `" . $cmtx_mysql_table_prefix . "comments` WHERE `is_approved` = '1' AND `rating` != '0' AND `page_id` = '$cmtx_page_id'");



    $average = mysql_fetch_assoc($result);



    $average = round($average["AVG(rating)"] / 0.5) * 0.5;



    return $average;



}





/* Product Listing */

foreach ($products as $product) { //loop through each product



    //Average Rating

    echo cmtx_average_rating($cmtx_page_id); // (change the $cmtx_page_id variable here, according to which product is in the loop)



}

?>

[azjol]

PHP Code:

<?php

function cmtx_average_rating ($cmtx_page_id) { //get average rating



    global $cmtx_mysql_table_prefix; //globalise variables



    $result = mysql_query("SELECT AVG(rating) FROM `" . $cmtx_mysql_table_prefix . "comments` WHERE `is_approved` = '1' AND `rating` != '0' AND `page_id` = '$cmtx_page_id'");



    $average = mysql_fetch_assoc($result);



    $average = round($average["AVG(rating)"] / 0.5) * 0.5;



    return $average;



}





/* Product Listing */

foreach ($products as $product) { //loop through each product



    //Average Rating

    echo cmtx_average_rating($cmtx_page_id); // (change the $cmtx_page_id variable here, according to which product is in the loop)



}

?>

[Steven]

Hi,

You didn't give any details of what you're trying to do, or how it's not working. I'm going to assume that you're not going through a loop like the original poster was doing. If so, try the following. I've added comments showing the things you need to change.

PHP Code:

<?php

function cmtx_average_rating($cmtx_page_id) {



    global $cmtx_mysql_table_prefix;



    $result = mysql_query("SELECT AVG(rating) FROM `" . $cmtx_mysql_table_prefix . "comments` WHERE `is_approved` = '1' AND `rating` != '0' AND `page_id` = '$cmtx_page_id'");



    $average = mysql_fetch_assoc($result);



    $average = round($average["AVG(rating)"] / 0.5) * 0.5;



    return $average;



}

?>



<?php

$cmtx_page_id = 'test'; //change this



define('IN_COMMENTICS', '1');

require 'comments/includes/db/connect.php'; //you *may* need to change this



$cmtx_page_id = htmlspecialchars($cmtx_page_id, ENT_QUOTES, 'UTF-8');

$cmtx_page_id = mysql_real_escape_string($cmtx_page_id);



$query = mysql_query("SELECT `id` FROM `" . $cmtx_mysql_table_prefix . "pages` WHERE `page_id` = '$cmtx_page_id'");

$result = mysql_fetch_assoc($query);

$id = $result['id'];



echo cmtx_average_rating($id);

?>

[azjol]

You explained it very exactly and everything is working now. Thank you very much for your help. AZJOL

[jonoweb]

PHP Code:

<?php

function cmtx_average_rating ($cmtx_page_id) { //get average rating



    global $cmtx_mysql_table_prefix; //globalise variables



    $result = mysql_query("SELECT AVG(rating) FROM `" . $cmtx_mysql_table_prefix . "comments` WHERE `is_approved` = '1' AND `rating` != '0' AND `page_id` = '$cmtx_page_id'");



    $average = mysql_fetch_assoc($result);



    $average = round($average["AVG(rating)"] / 0.5) * 0.5;



    return $average;



}





/* Product Listing */

foreach ($products as $product) { //loop through each product



    //Average Rating

    echo cmtx_average_rating($cmtx_page_id); // (change the $cmtx_page_id variable here, according to which product is in the loop)



}

?>